KLE classification integrated in miniscanner. #4
Conversation
…m height and causing it to stretch. It also does not reload the page, causing a useless miniscan() from the backend.
… for text input field is hard-coded at 2000 in checkTextSize.js
…js file that handled that before as well as prior translations.
…supported at the moment.
…s/miniscanner/miniscan_results.html Co-authored-by: Alexander Faithfull <[email protected]>
…html Co-authored-by: Alexander Faithfull <[email protected]>
Co-authored-by: Alexander Faithfull <[email protected]>
…d test_miniscanner now have variable and function names in snake_case.
…so fixed the redundant class problem in the test file.
|
Another issue is the front-end and how we display the classification results. For now, they are with the match results for the rules, but will probably be moved further below or somewhere else. |
|
Can I ask you to rebase this on |
src/os2datascanner/projects/admin/adminapp/views/data/OS2KLE.json
Outdated
Show resolved
Hide resolved
...s2datascanner/projects/admin/adminapp/templates/components/miniscanner/miniscan_results.html
Outdated
Show resolved
Hide resolved
…ading ? Did i do a mistake ?
…a prepare.sh in /code/resources/downloads/os2kledata/. Add a blank rule like regex() for when only using classification ?
|
Error in my commit message. I meant a regex like $a since it will never be True. Good luck finding a string with a after the end of the string. Could be useful if the user wants to only use the classification function. |
|
Might need to refactor pytest for miniscanner now that i reworked the kle results. |
Just tested the miniscanner, passed all tests. Running all the tests raises an import error in another test file, probably due to the path of the imported file changing. |
There is now the option to enable (or not) KLE classification, using a checkbox below the textfield. The main issue is speed, as this classification uses a really large json file (~11Mb), and the request takes around 2 seconds to do the trip.