Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Impending mechanic #12865

Merged
merged 4 commits into from
Sep 14, 2024
Merged

Implement Impending mechanic #12865

merged 4 commits into from
Sep 14, 2024

Conversation

theelk801
Copy link
Contributor

@theelk801 theelk801 commented Sep 13, 2024

This should be good to go

@github-actions github-actions bot added the tests label Sep 13, 2024
@theelk801 theelk801 marked this pull request as ready for review September 13, 2024 17:00
Copy link
Contributor

@xenohedron xenohedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

private static final String hauntwoods = "Overlord of the Hauntwoods";

public void assertHasImpending(String name, boolean hasAbility) {
Permanent permanent = getPermanent(hauntwoods);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should use the name param rather than hardcoding

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops good catch thanks

@theelk801 theelk801 merged commit d923f29 into master Sep 14, 2024
1 check passed
@xenohedron xenohedron deleted the feature/implement-impending branch September 14, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants