Added hints about number of lands to some cards #12800
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayDi85
reviewed
Sep 4, 2024
| private static final FilterControlledPermanent filter = new FilterControlledPermanent("Forest you control"); | ||
|
|
||
| static { | ||
| filter.add(SubType.FOREST.getPredicate()); | ||
| } | ||
|
|
||
| public BeaconOfCreation(UUID ownerId, CardSetInfo setInfo) { | ||
| super(ownerId,setInfo,new CardType[]{CardType.SORCERY},"{3}{G}"); | ||
| super(ownerId, setInfo, new CardType[]{CardType.SORCERY}, "{3}{G}"); | ||
|
|
||
|
|
||
| // Create a 1/1 green Insect creature token for each Forest you control. | ||
| this.getSpellAbility().addEffect(new CreateTokenEffect(new InsectToken(), new PermanentsOnBattlefieldCount(filter))); |
There was a problem hiding this comment.
If possible then must use shared xValue in both hint and effect:
I prefer to show it as card hint, so users can see/calc possible P/T values before cast (e.g. in hand/stack). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added hints to 42 cards which care about having certain amount of lands of the basic type
My implementation of Last Stand is somewhat cumbersome and bothers me, but I haven't found any better ways in the current hints implementation. Probably missing something
Also I didn't add hints to creatures with x/x of stats where x if the amount of (Basic land type), but I may still add them if they are needed