Multiple fixes and prettification of errors #12
Conversation
stelcheck
force-pushed
the
fixes/a-whole-bunch-and-more
branch
from
42eeccd
to
99dd1ad
Compare
| * Force-configure mage to use cluster: 1 (one master, one process), | ||
| * and set the list of files and folders to watch for. | ||
| */ | ||
| var config = require('../mage/lib/config'); |
There was a problem hiding this comment.
Why the ../ before mage? Module resolution should find mage/lib/config just fine, right?
| var watcher = watch(WATCH_FILES, { | ||
| recursive: true | ||
| }, function (event, name) { | ||
| if (name.split(path.sep).pop()[0] === '.') { |
There was a problem hiding this comment.
I know this code existed before, but what is this about? Hidden files? Why ignore them exactly? (.DS_Store and stuff?)
There was a problem hiding this comment.
Correct. IIRC WebStorm and some other IDEs create and update dot files on file save; this was a quick fix to ensure file watch woild not trigger more than once (arguably not a real fix, but in this case it got the job done).
index.js
Outdated
| } | ||
|
|
||
| var rendered = prettyError.render(error); | ||
| rendered = rendered.substring(0, rendered.length - 5); |
There was a problem hiding this comment.
Friendly tip:
rendered = rendered.slice(0, -5);
index.js
Outdated
| } else { | ||
| console.log(''); | ||
| logger.warning('------------------------------------------------------'); | ||
| logger.warning('Worker down, save a file of press any key to reload...'); |
|
Wow, that's a lot to take in :) Sounds promising though! |
stelcheck
force-pushed
the
fixes/a-whole-bunch-and-more
branch
from
99dd1ad
to
ed32bb5
Compare
|
Will release alongside the next MAGE release. |
|
Is there a dependency on the upcoming MAGE release? |
|
Yes, mage/mage#173 is needed. |
Fixes multiple outstanding issues, and pretifies error output by:
Fixes #4 #5 #8 #9 #11
cc @Tatsujinichi @ronkorving