React Native support for backbone-react-component #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| // Sets `this.el` and `this.$el` when the component updates. | ||
| componentDidUpdate: function () { | ||
| this.setElement(React.findDOMNode(this)); |
There was a problem hiding this comment.
Maybe something like if (React.findDOMNode) is better to avoid having to set an extra flag for it (isReactNative)?
|
Hi @visigoth. I commented the changes a little bit, please take a look 👍 |
React Native 0.14.0's packager fails when a require() doesn't resolve (rather than dispatching a caught exception).
|
@visigoth it seems you're still working on your fork. What's the status on it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these changes seem to be the minimal amount needed to make backbone-react-component usable in react-native. it's been really useful to me and i figure others will find backbone-react-component handy in their react-native projects as well.