Fix duplicate check of mfamigration #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamErde
suggested changes
Feb 5, 2025
There was a problem hiding this comment.
This PR should only contain changes related to the description:
CISA Test "MS.AAD.3.5: The authentication methods SMS, Voice Call, and Email One-Time Passcode (OTP) SHALL be disabled." fails if MFA Migrations is not completet but the weak factors are disabled.
But CISA Test "MS.AAD.3.4: The Authentication Methods Manage Migration feature SHALL be set to Migration Complete." already checks if mfa migration is completed.
This will make review, approval, and merging easier to safely manage.
…ation next to week factors. Removed mfa migration check as a separate test already exists.
HenrikPiecha
force-pushed
the
fix-duplicate-check-of-mfamigration
branch
from
79cf8d0 to
fc845d4
Compare
|
Removed commits that are handeled in separate PR. |
merill
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CISA Test "MS.AAD.3.5: The authentication methods SMS, Voice Call, and Email One-Time Passcode (OTP) SHALL be disabled." fails if MFA Migrations is not completet but the weak factors are disabled.
But CISA Test "MS.AAD.3.4: The Authentication Methods Manage Migration feature SHALL be set to Migration Complete." already checks if mfa migration is completed.