-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MS.AAD.6.1): password expiration must be configured for all domains #603
Conversation
In my opinion, it's a good practice to check all domains, as the 'primary domain' does not always technically appear as 'isDefault.' |
Added comment #594 (comment) |
Holding PR to update test to align with suggestion from @soulemike (see link above). I agree more details here would be good. Likely returning each domain in a table with the configuration and pass state, similar to other tests. Something like the below. With the test result validating all verified managed and federated domains are valid.
Reviewing the CISA REGO it looks like they do something similar and measure the aggregate, so just looks like something I missed when wiring this up. https://github.com/cisagov/ScubaGear/blob/main/PowerShell/ScubaGear/Rego/AADConfig.rego#L681 @weyCC81 let us know if you would like to pick this up, if not I can take a stab. Thanks! |
Updated PR to include details. Realized I missed a skip condition. Adding it quick. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
addresses #594
This may be an opinionated change, and I am happy to discuss.
To comply with MS.AAD.6.1, all verified domains should be evaluated for this configuration value.
If configuring the primary domain is sufficient for compliance (i.e. the configured value for non-primary domains becomes irrelevant), then the
isDefault
attribute should be used to filter the results down to a single domain.This PR is with the following requirement in mind:
ALL verified managed domains shall be configured to not require password expiry.