Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exchange Settings Tests #530

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

weyCC81
Copy link
Contributor

@weyCC81 weyCC81 commented Nov 9, 2024

Exchange Settings
I have extended the Tests which are not related to EIDSCA or CISA, which are also in the M365 Secure Score for the area exchange.

@weyCC81 weyCC81 requested a review from a team as a code owner November 9, 2024 12:51
@merill
Copy link
Contributor

merill commented Dec 8, 2024

@weyCC81 Thank you so much for this really good PR, and I'm super sorry on the delay in getting back to you on this.

Would it be possible to move the code for this test into a cmdlet instead of the tests file. You can also move the markdown into .md files (see the code samples for one of the other tests).

This ways its easier to make updates/bug fixes to the module and push them through instead of overwriting any changes users might make to their file.

@merill
Copy link
Contributor

merill commented Dec 14, 2024

I've added numbering to the tests. Will include these along with the other set of tests where we want to move them to PowerShell modules and improve the docs/guidance

@merill merill merged commit 7bf2bef into maester365:main Dec 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants