Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dispatch2): Add 'static bound to exec_async #690

Merged
merged 1 commit into from
Jan 12, 2025
Merged

fix(dispatch2): Add 'static bound to exec_async #690

merged 1 commit into from
Jan 12, 2025

Conversation

jesdazrez
Copy link
Contributor

Closes #689.

madsmtm
madsmtm requested changes Jan 6, 2025
View reviewed changes
Copy link
Owner

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do the same for Group::exec_async, Queue::barrier_async and Queue::barrier_async_and_wait?

And add a changelog entry?

@madsmtm madsmtm added enhancement New feature or request A-dispatch2 Affects the `dispatch2` crate bug Something isn't working and removed enhancement New feature or request labels Jan 6, 2025
@jesdazrez
Copy link
Contributor Author

sure thing!

@jesdazrez jesdazrez force-pushed the dispatch_soundness_fix branch from 716af43 to a69ad08 Compare January 12, 2025 02:26
@jesdazrez
Copy link
Contributor Author

done!

@jesdazrez jesdazrez requested a review from madsmtm January 12, 2025 02:26
madsmtm
madsmtm approved these changes Jan 12, 2025
View reviewed changes
Copy link
Owner

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@madsmtm madsmtm merged commit 3d888a0 into madsmtm:master Jan 12, 2025
20 checks passed
@madsmtm madsmtm added I-unsound A soundness hole and removed I-unsound A soundness hole labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

Assignees
No one assigned
Labels
A-dispatch2 Affects the `dispatch2` crate bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Queue::exec_async can be mis-used with just safe code
2 participants
@jesdazrez @madsmtm