Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TFIBCustomDataSet.DoFieldValidate getting empty value on date fields #78

Closed
wants to merge 1 commit into from

Conversation

did-vmonroig
Copy link
Contributor

Previous fix #76 broke validation of date fields, entering on their OnValidate event always with Null value.

@madorin
Copy link
Owner

madorin commented Mar 31, 2024

@did-vmonroig , can you make a simple test case with two fields date and integer or other types to investigate it better?
I see TFIBDateField.SetAsDateTime have a strange override and it seems need to be fixed in another way.

Unfortunatelly I cannot accept this case specific merge request with if Field is TIntegerField then

@madorin madorin self-assigned this Mar 31, 2024
@did-vmonroig
Copy link
Contributor Author

@madorin, I understand my fix is not good but I tried to made progress with no luck. Something is broken in Fibplus when using Delphi from 10.x to most recent. Issues #77 and #83 seems related to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants