Add Blackman-Harris window function and create go.mod file #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddyblue
reviewed
Oct 9, 2023
| bartlett []float64 | ||
| flatTop []float64 | ||
| blackman []float64 | ||
| in int |
| @@ -0,0 +1,3 @@ | |||
| module github.com/mjibson/go-dsp | |||
|
|
|||
| go 1.21.1 | |||
There was a problem hiding this comment.
Adding this file would definitely need to be in a separate PR. And since this repo doesn't have any tests, I'm not inclined to do that because I'm worried about unknown breakage. Also it should be the lowest supported go version, not the highest. In summary this change would need:
- separate PR
- running
go testin a github action - minimum supported go version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a function for a Blackman-Harris window to the
windowpackage as well as the relevant tests. I ran into an issue usinggo testto runwindow_test.go, so I rango mod init && go mod tidyin the root directory to add ago.modfile.Currently
go testwill fail for a 10-point Blackman-Harris window because I didn't add enough digits to the test case inwindow_test.go, and I'm not sure how to get more precision from Matlab at the moment. However, I implemented the function exactly as it appears in https://www.mathworks.com/help/signal/ref/blackmanharris.html so I'm confident it's doing the correct calculations.