Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmlint: fix build on old systems, fix universal variant #15003

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

barracuda156
Copy link
Contributor

Description

As per the title. Fix the build for Leopard and SL, fix universal variant, which otherwise is mishandled by SCons.
(gcc-4.2 still fails to build rmlint even when incompatible optional flag is removed, so blacklist it.)

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6 PPC (10A190)
Xcode 3.2

macOS 10.5.8
Xcode 3.1.4

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@herbygillot for port rmlint.

@barracuda156
Copy link
Contributor Author

PR to the source: sahib/rmlint#573 (without universal part, obviously).

@herbygillot herbygillot merged commit 7bf0bb5 into macports:master Jun 1, 2022
@barracuda156 barracuda156 deleted the rmlint branch June 1, 2022 19:44
@barracuda156
Copy link
Contributor Author

@herbygillot Thanks!

@herbygillot
Copy link
Member

Thanks for looking into this @barracuda156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: bugfix
Development

Successfully merging this pull request may close these issues.

3 participants