Preparation before linting

mackoj · Dec 14, 2019 · 9a689ac · 9a689ac
1 parent 23d4421
commit 9a689ac
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 7 deletions.
diff --git a/.swift-format b/.swift-format
@@ -48,6 +48,6 @@
     "UseTripleSlashForDocumentationComments" : true,
     "ValidateDocumentationComments" : true
   },
-  "tabWidth" : 8,
+  "tabWidth" : 4,
   "version" : 1
 }
diff --git a/Makefile b/Makefile
@@ -7,6 +7,9 @@ build:
 reformat:
 	swift-format -m format --configuration .swift-format -r -i Sources
 
+lint:
+	swift-format -m lint --configuration .swift-format -r -i Sources
+
 gitignore-flush:
 	git rm -r --cached .
 	git add .

diff --git a/Sources/PlatformLookup/PlatformLookup+FindDevices.swift b/Sources/PlatformLookup/PlatformLookup+FindDevices.swift
@@ -66,9 +66,7 @@ extension PlatformLookup {
     -> String?
   {
     if let platform = try getAllDevices(with: deviceFilter, runtimeFilter: runtimeFilter).last {
-      return """
-        platform="iOS Simulator,name=\(platform.devices.last!.name),OS=\(platform.runtime.version)"
-        """
+      return "iOS Simulator,name=\(platform.devices.last!.name),OS=\(platform.runtime.version)"
     }
     return nil
   }

diff --git a/TODO.md b/TODO.md
@@ -1,9 +1,15 @@
 # TODO
 
+## P0
+- [ ] Add missing tests
+
+## P1
 - [ ] Code Documentation
 - [ ] Project Documentation
-- [ ] Dr String
-- [ ] Developer Jouney
+- [ ] Developer Jouney (comment participer au projet)
+
+## P2
 - [ ] Code of conduct
 - [ ] PR Boiler plate
 - [ ] Auto review ?
+- [ ] Dr String
diff --git a/Tests/PlatformLookupTests/PlatformLookupTests.swift b/Tests/PlatformLookupTests/PlatformLookupTests.swift
@@ -41,7 +41,7 @@ final class PlatformLookupTests: XCTestCase {
   }
   func test_findADeviceForLastOSVersion_string() {
     let platform: String? = try? PlatformLookup.findADeviceForLastOSVersion()
-    XCTAssertEqual(platform, "platform=\"iOS Simulator,name=iPhone 11 Pro Max,OS=13.2\"")
+    XCTAssertEqual(platform, "iOS Simulator,name=iPhone 11 Pro Max,OS=13.2")
   }
   func test_findADeviceForLastOSVersion_platform() {
     let platform: Platform? = try? PlatformLookup.findADeviceForLastOSVersion()