Reduce check-log errors when a file in the log directory has been removed at the moment of running check-log #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved at the moment of running check-log
ne-sachirou
deleted the
check-log-reduce-errors-when-a-file-in-log-dir-have-just-been-removed
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 similer problems.
os.ReadDirfunction may return an error from lstat when the file is removed within the period of runningos.ReadDirfunction. If the error occurs,os.ReadDirfunction returns entries it was able to read before the error https://pkg.go.dev/[email protected]#ReadDir .DirEntry.Infomethod may return an error when the file is removed between the process runsos.ReadDirfunction and runsDirEntry.Infomethod. The error satisfieserrors.Is(err, ErrNotExist)accroding to https://pkg.go.dev/io/[email protected]#DirEntry .