Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customize wrap template #42

Open
Eseperio opened this issue Oct 10, 2017 · 1 comment
Open

Allow customize wrap template #42

Eseperio opened this issue Oct 10, 2017 · 1 comment

Comments

@Eseperio
Copy link

yii2-notifications/assets/notifications.js

Line 213 in d21a02b

html +

In spite of the listItemTemplate is customizable it is not enough useful, because it is wrapped into a fixed div. When using, as an example, AdminLTE it can´t fit the requirements of this theme, because it requires an unordered list.

Adding a parameter like tagNameor containerTemplate can make it easy to reach.
@machour
Copy link
Owner

machour commented Oct 10, 2017

Good catch. I'll gladly merge a PR for this if you want to propose one

@Eseperio Eseperio mentioned this issue Oct 13, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@machour @Eseperio