Added yaml_dict.get call to add id to notebook and updated template.y…

…aml to match Katalog. (#245)

Signed-off-by: JAulet <[email protected]>

api/server/swagger_server/controllers_impl/notebook_service_controller_impl.py

@@ -388,7 +388,7 @@ def _upload_notebook_yaml(yaml_file_content: AnyStr, name=None, access_token=Non
 
     template_metadata = yaml_dict.get("metadata") or dict()
 
-    notebook_id = existing_id or generate_id(name=name or yaml_dict["name"])
+    notebook_id = existing_id or yaml_dict.get("id") or generate_id(name=name or yaml_dict["name"])
     created_at = datetime.now()
     name = name or yaml_dict["name"]
     description = yaml_dict["description"].strip()

notebooks/template.yaml

@@ -1,11 +1,13 @@
 # Copyright 2021 The MLX Contributors
 #
 # SPDX-License-Identifier: Apache-2.0
-name: <notebook_name> # required
+
+id: <notebook_id> # Required, must be DNS-1123 subdomain, lower case alphanumeric characters and '-'
+name: <notebook_name> # Required
 description: <notebook_description> # Optional
 metadata: # Optional metadata
   annotations:
     platform: <notebook_platform>
-implementation: # required
+implementation: # Required
   github:
     source: <notebook_github_URL>