Fix Powershell in CMD being mis-detected #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spowelljr : This would need an upstream issue and PR as well, at https://github.com/docker/machine Sounds good to me, I'm not sure how many start new CMD shells from their Powershell - but if they do... |
|
@afbjorklund Thanks for merging, I'll make an upstream issue and PR as well. |
|
Not holding my breath that anyone will ever look at it, but just in case... |
|
Upstream issue docker#4891 & PR docker#4892 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you spawn a Powershell instance from CMD, sometimes the SHELL environment variable still points to CMD in the Powershell instance. So if SHELL is pointing to CMD, let's do extra work to get the correct shell.