Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard handler for collapse/expanding #357

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Keyboard handler for collapse/expanding #357

wants to merge 9 commits into from

Conversation

nictownsend
Copy link

  • Braces, String and Function keyboard handler

Fixes #355

@nictownsend
Copy link
Author

This PR is the bare minimum to add keyboard support for collapsing/expanding braces/functions/strings with tab index, keydown handler, and aria roles/attributes

@nictownsend
Copy link
Author

@mac-s-g is there a set of maintainers I should assign for review?

@galr52
Copy link

galr52 commented Jun 16, 2021

@mac-s-g is there a set of maintainers I should assign for review?

my pr is also waiting for @mac-s-g response.
In the meantime, i have created and published a fork :)
https://github.com/galr52/react-extreme-json-view

collapse/expand braces, strings and functions

Fixes #355
@nictownsend
Copy link
Author

@mac-s-g is there a set of maintainers I should assign for review?

my pr is also waiting for @mac-s-g response. In the meantime, i have created and published a fork :) https://github.com/galr52/react-extreme-json-view

@galr52 - it looks like your 1.22 publish doesn't have my changes built in it, could you please rebuild + publish again?

@galr52
Copy link

galr52 commented Nov 30, 2021

@mac-s-g is there a set of maintainers I should assign for review?

my pr is also waiting for @mac-s-g response. In the meantime, i have created and published a fork :) https://github.com/galr52/react-extreme-json-view

@galr52 - it looks like your 1.22 publish doesn't have my changes built in it, could you please rebuild + publish again?

i rebuild & published

@nictownsend
Copy link
Author

https://codesandbox.io/s/react-extreme-json-test-mcujc - it doesn't seem to have those changes when using the latest. The elements should have role=button if my changes are in the build

@galr52
Copy link

galr52 commented Dec 1, 2021

https://codesandbox.io/s/react-extreme-json-test-mcujc - it doesn't seem to have those changes when using the latest. The elements should have role=button if my changes are in the build

sorry, you are right. my mistake. try the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigate tree using keyboard interactions
2 participants