-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard handler for collapse/expanding #357
base: master
Are you sure you want to change the base?
Conversation
This PR is the bare minimum to add keyboard support for collapsing/expanding braces/functions/strings with tab index, keydown handler, and aria roles/attributes |
@mac-s-g is there a set of maintainers I should assign for review? |
my pr is also waiting for @mac-s-g response. |
collapse/expand braces, strings and functions Fixes #355
@galr52 - it looks like your |
i rebuild & published |
https://codesandbox.io/s/react-extreme-json-test-mcujc - it doesn't seem to have those changes when using the latest. The elements should have |
sorry, you are right. my mistake. try the latest version |
Fixes #355