Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make sure xhprof is installed #21

Merged
merged 1 commit into from
Oct 28, 2024
Merged

docs: make sure xhprof is installed #21

merged 1 commit into from
Oct 28, 2024

Conversation

phh
Copy link
Contributor

@phh phh commented Oct 25, 2024

Since this package uses the Spiral profiler package this package might specify the same requirements.

It might be obvious that you need Xhprof before this package can run, however, by just installing the package without the extension you just get an error:

Undefined constant "SpiralPackages\Profiler\Driver\XHPROF_FLAGS_MEMORY"

I've also decided not to link to Uprofiler or Tideways as these are both archived.

@maantje maantje merged commit bbdc85b into maantje:main Oct 28, 2024
1 check passed
@maantje
Copy link
Owner

maantje commented Oct 28, 2024

Hey @phh,

Thank you for clarifying the Xhprof requirement in the README!

@phh phh deleted the patch-1 branch October 28, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants