Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable middleware. When we try to profile some part of… #19

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

ARTWINPRO
Copy link
Contributor

No description provided.

@butschster
Copy link

@maantje ping

@maantje
Copy link
Owner

maantje commented Jun 30, 2024

Hey @ARTWINPRO,

Thank you for your contribution!

Am I understanding correctly that you want to add this so you can get the profiler out of the container to start/stop it only for the relevant parts you want to profile?

I also find XHPROF_ON_STARTUP to be a confusing name as to what it is supposed to do. Could you rename it to XHPROF_REGISTER_MIDDLEWARE, defaulting to true?

@ARTWINPRO
Copy link
Contributor Author

@maantje good day.
Changes have been made. Always happy to help.

@maantje maantje merged commit e17d29a into maantje:main Jul 15, 2024
5 checks passed
@maantje
Copy link
Owner

maantje commented Jul 15, 2024

Hey @ARTWINPRO,

Thank you for the changes. I have merged the PR and will be creating a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants