Better detection of available LSP client #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify function ccls#lsp#request so that when the current vim has both vim-lsp / nvim-lspconfig plugins loaded, we can correctly detect the one truely in-use. Still prefer vim-lsp to nvim-lspconfig, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify function ccls#lsp#request so that when the current vim has both vim-lsp / nvim-lspconfig plugins loaded, we can correctly detect the one truely in-use.
Still prefer vim-lsp to nvim-lspconfig, though.
In my senario, I have both vim-lsp and nvim-lspconfig loaded, but I actually use and configure the nvim-lspconfig. The vim-lsp is not used and not configured. Calling :CclsCallHierarchy give me a confusing "ccls language server unvailable" errmsg.
It seems that we are using "exists('*lsp#send_request')" to check whether vim-lsp is usable and go in to the deap branch too early.