-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kasli_i2c: fix EEPROM access issue in DRTIO networks #2692
base: master
Are you sure you want to change the base?
Conversation
self.sw0 = dmgr.get(sw0_device) | ||
self.sw1 = dmgr.get(sw1_device) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks dodgy.
Signed-off-by: Florian Agbuya <[email protected]>
Signed-off-by: Florian Agbuya <[email protected]>
# Skip master-side switch operations for satellite EEPROMs | ||
if (self.busno >> 16) == 0: | ||
mask = 1 << self.port | ||
if self.port < 8: | ||
self.sw0.set(self.port) | ||
self.sw1.unset() | ||
else: | ||
self.sw0.unset() | ||
self.sw1.set(self.port - 8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work?!
The switches obviously need to be set on the satellites instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand, this still works upon testing because remote_i2c
automatically sets the switches based on the destination parameter, unlike local_i2c
which needs to be set manually.
ARTIQ Pull Request
Description of Changes
Fix DRTIO EEPROM access for Urukul:
KasliEEPROM
to encodeDRTIO
destinationEEPROM
sTest results:
Before:
After:
Related Issue
Closes #2687
Type of Changes
Steps (Choose relevant, delete irrelevant before submitting)
All Pull Requests
git commit --signoff
, see copyright).Code Changes
flake8
to check code style (follow PEP-8 style).flake8
has issues with parsing Migen/gateware code, ignore as necessary.Git Logistics
git rebase --interactive
). Merge/squash/fixup commits that just fix or amend previous commits. Remove unintended changes & cleanup. See tutorial.git show
). Format:Licensing
See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.