Skip to content

Commit

Permalink
Adds flag --enable-feature=memory-snapshot-on-shutdown (#864)
Browse files Browse the repository at this point in the history
* Adds flag --enable-feature=memory-snapshot-on-shutdown

This is an experimental feature which is supposed to make startups
faster. This is running in the platform cluster and seems to work as
advertised.

* Enables feature memory-snapshot-on-shutdown in dataproc

This is added to prometheus-federation and platform cluster already.
  • Loading branch information
nkinkade authored Jan 12, 2022
1 parent b3ecbca commit cdd2a2a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion k8s/data-processing/deployments/prometheus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ spec:
args: ["--config.file=/etc/prometheus/prometheus.yml",
"--storage.tsdb.retention.time=120d",
"--storage.tsdb.path=/data",
"--web.enable-lifecycle"]
"--web.enable-lifecycle",
"--enable-feature=memory-snapshot-on-shutdown"]
ports:
- containerPort: 9090
resources:
Expand Down
3 changes: 2 additions & 1 deletion k8s/prometheus-federation/deployments/prometheus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ spec:
"--storage.tsdb.path=/prometheus",
"--storage.tsdb.retention.time=120d",
"--web.enable-lifecycle",
"--web.external-url=https://prometheus.{{GCLOUD_PROJECT}}.measurementlab.net"]
"--web.external-url=https://prometheus.{{GCLOUD_PROJECT}}.measurementlab.net",
"--enable-feature=memory-snapshot-on-shutdown"]
ports:
- containerPort: 9090
resources:
Expand Down

0 comments on commit cdd2a2a

Please sign in to comment.