-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline and Modal background image layouts #326
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,5 @@ docs/docs/examples/preview | |
.env.json | ||
package-lock.json | ||
coverage/ | ||
yarn.lock | ||
yarn.lock | ||
.vscode |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.inline-module { | ||
width: 400px; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<div class="inline-module"></div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
var module = new pathfora.Subscription({ | ||
id: 'message-inline', | ||
layout: 'inline', | ||
position: '.inline-module', | ||
headline: 'Welcome!', | ||
msg: 'Please sign up for our newsletter for more updates.', | ||
variant: 4, | ||
backgroundImage: { | ||
src: '../../../../assets/desk.png' | ||
} | ||
}); | ||
|
||
pathfora.initializeWidgets([module]); |
3 changes: 3 additions & 0 deletions
3
docs/docs/examples/src/layouts/inline/backgroundImagePosition.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.inline-module { | ||
width: 600px; | ||
} |
1 change: 1 addition & 0 deletions
1
docs/docs/examples/src/layouts/inline/backgroundImagePosition.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<div class="inline-module"></div> |
14 changes: 14 additions & 0 deletions
14
docs/docs/examples/src/layouts/inline/backgroundImagePosition.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
var module = new pathfora.Subscription({ | ||
id: 'message-inline', | ||
layout: 'inline', | ||
position: '.inline-module', | ||
headline: 'Welcome!', | ||
msg: 'Please sign up for our newsletter for more updates.', | ||
variant: 4, | ||
backgroundImage: { | ||
src: '../../../../assets/desk.png', | ||
position: 'left' | ||
} | ||
}); | ||
|
||
pathfora.initializeWidgets([module]); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
var module = new pathfora.Form({ | ||
id: 'modal-background', | ||
layout: 'modal', | ||
headline: 'Sign Up!', | ||
msg: 'Submit this form to get updates', | ||
variant: 4, | ||
backgroundImage: { | ||
src: '../../../../assets/desk.png' | ||
} | ||
}); | ||
|
||
pathfora.initializeWidgets([module]); |
13 changes: 13 additions & 0 deletions
13
docs/docs/examples/src/layouts/modal/backgroundImageBottom.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
var module = new pathfora.Form({ | ||
id: 'modal-background', | ||
layout: 'modal', | ||
headline: 'Sign Up!', | ||
msg: 'Submit this form to get updates', | ||
variant: 4, | ||
backgroundImage: { | ||
src: '../../../../assets/desk.png', | ||
position: 'bottom' | ||
} | ||
}); | ||
|
||
pathfora.initializeWidgets([module]); |
13 changes: 13 additions & 0 deletions
13
docs/docs/examples/src/layouts/modal/backgroundImageLeft.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
var module = new pathfora.Form({ | ||
id: 'modal-background', | ||
layout: 'modal', | ||
headline: 'Sign Up!', | ||
msg: 'Submit this form to get updates', | ||
variant: 4, | ||
backgroundImage: { | ||
src: '../../../../assets/desk.png', | ||
position: 'left' | ||
} | ||
}); | ||
|
||
pathfora.initializeWidgets([module]); |
13 changes: 13 additions & 0 deletions
13
docs/docs/examples/src/layouts/modal/backgroundImageRight.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
var module = new pathfora.Form({ | ||
id: 'modal-background', | ||
layout: 'modal', | ||
headline: 'Sign Up!', | ||
msg: 'Submit this form to get updates', | ||
variant: 4, | ||
backgroundImage: { | ||
src: '../../../../assets/desk.png', | ||
position: 'right' | ||
} | ||
}); | ||
|
||
pathfora.initializeWidgets([module]); |
13 changes: 13 additions & 0 deletions
13
docs/docs/examples/src/layouts/modal/backgroundImageTop.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
var module = new pathfora.Form({ | ||
id: 'modal-background', | ||
layout: 'modal', | ||
headline: 'Sign Up!', | ||
msg: 'Submit this form to get updates', | ||
variant: 4, | ||
backgroundImage: { | ||
src: '../../../../assets/desk.png', | ||
position: 'top' | ||
} | ||
}); | ||
|
||
pathfora.initializeWidgets([module]); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be something we need to discuss in person, but what was the deciding factor on making this a separate variant? Given the existing patterns with variants, it does sort of make sense. But in general I think we want to avoid using variants in the future as they are kind of a bad API design, and I think we'd like to support background images on other variant modals such as content recommendations.