Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update references to lio to fallback to jstag when not found #313

Merged
merged 10 commits into from
Jan 21, 2019

Conversation

markhayden
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #313 into develop will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #313      +/-   ##
==========================================
+ Coverage    89.46%   89.6%   +0.13%     
==========================================
  Files          109     109              
  Lines         2069    2087      +18     
  Branches       629     638       +9     
==========================================
+ Hits          1851    1870      +19     
+ Misses         218     217       -1
Impacted Files Coverage Δ
src/rollup/validation/validate-account-id.js 100% <100%> (ø) ⬆️
...y-conditions/entity-fields/replace-entity-field.js 95.65% <100%> (+0.53%) ⬆️
src/rollup/data/segments/get-user-segments.js 100% <100%> (+25%) ⬆️
src/rollup/callbacks/add-callback.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0e2e9...e4c5bda. Read the comment docs.

@markhayden markhayden changed the title update references to lio to fallback to jstag when not found [WIP] update references to lio to fallback to jstag when not found Nov 1, 2018
dist/pathfora.js Show resolved Hide resolved
dist/pathfora.js Show resolved Hide resolved
test/acceptance/content-recommendation.spec.js Outdated Show resolved Hide resolved
test/acceptance/prioritized-widgets.spec.js Outdated Show resolved Hide resolved
Copy link
Contributor

@ashyablok ashyablok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@markhayden markhayden merged commit b9a84b2 into develop Jan 21, 2019
@markhayden markhayden deleted the issue/support-jstag-3 branch January 21, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants