Merge with origin/main: all histories cleared

src/Lynx/Engine.cs

@@ -2,6 +2,7 @@
 using Lynx.UCI.Commands.Engine;
 using Lynx.UCI.Commands.GUI;
 using NLog;
+using System;
 using System.Threading.Channels;
 
 namespace Lynx;
@@ -83,12 +84,17 @@ public void NewGame()
         Game = new Game();
         _isNewGameComing = true;
         _isNewGameCommandSupported = true;
-        InitializeTT();
 
+        InitializeTT(); // TODO SPRT clearing instead
+
+        // Clear histories
         for (int i = 0; i < 12; ++i)
         {
+            Array.Clear(_quietHistory[i]);
             for (var j = 0; j < 64; ++j)
             {
+                Array.Clear(_captureHistory[i][j]);
+
                 //for (int contPly = 0; contPly < 2; ++contPly)
                 //{
 
@@ -99,6 +105,8 @@ public void NewGame()
                 //}
             }
         }
+
+        // No need to clear killer move or pv table because they're cleared on every search (IDDFS)
     }
 
     public void AdjustPosition(ReadOnlySpan<char> rawPositionCommand)

src/Lynx/Search/IDDFS.cs

@@ -57,12 +57,6 @@ public sealed partial class Engine
     private bool _isScoringPV;
 
     private SearchResult? _previousSearchResult;
-    private readonly int[][] _previousKillerMoves =
-    [
-        new int[Configuration.EngineSettings.MaxDepth],
-        new int[Configuration.EngineSettings.MaxDepth],
-        new int[Configuration.EngineSettings.MaxDepth]
-    ];
 
     private readonly Move _defaultMove = default;
 
@@ -168,8 +162,6 @@ public sealed partial class Engine
                 lastSearchResult = UpdateLastSearchResult(lastSearchResult, bestEvaluation, alpha, beta, depth, isMateDetected, bestEvaluationAbs);
 
                 await _engineWriter.WriteAsync(InfoCommand.SearchResultInfo(lastSearchResult));
-
-                Array.Copy(_killerMoves, _previousKillerMoves, _killerMoves.Length);
             } while (StopSearchCondition(++depth, maxDepth, isMateDetected, decisionTime));
         }
         catch (OperationCanceledException)