Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor locations (version 2) #519

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Refactor locations (version 2) #519

merged 2 commits into from
Oct 7, 2023

Commits on Oct 7, 2023

  1. Refactor locations (version 2) 

    This is a significantly lighter refactor than #518. To wit,

- The absent status remains. We move people to the square or their house
  depending on their absent status at beginning of day, but otherwise
  location during daytime does not impact ability to vote by itself.
- Locations are singleton objects based on their name and do not carry
  any game state in the object itself. All game state is stored in
  GameState itself.
- There are no location subclasses; everything is just directly a
  Location.
- All access to location data is done via the locations APIs rather than
  directly modifying the GameState variables. This allows for easier
  future refactors of how we are storing data.
    @skizzerz
    skizzerz committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    aa5290b View commit details
    Browse the repository at this point in the history

  2. Update wolf behavior 

    Missed this in my initial passthrough. This PR is now tested though ;)
    @skizzerz
    skizzerz committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    946c19e View commit details
    Browse the repository at this point in the history