Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark outdated plan checkruns as aborted #701

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

asubrocky
Copy link
Contributor

This change makes the PR workflow mark outdated plan checkruns as aborted.

Why?

  • During our testing, we encountered an issue where if commits were rapidly created on a PR, some checkruns for older revisions could be stuck in pending or in progress state.

@asubrocky asubrocky force-pushed the mark-outdated-plan-checkruns-as-aborted branch 2 times, most recently from b6409e4 to 25417ed Compare June 28, 2023 16:18
This change makes the PR workflow mark outdated plan checkruns as aborted.

Why?
* During our testing, we encountered an issue where if commits were rapidly created on a PR, some checkruns for older revisions could be stuck in pending or in progress state.
@asubrocky asubrocky force-pushed the mark-outdated-plan-checkruns-as-aborted branch from 25417ed to a80aa16 Compare June 28, 2023 16:24
@asubrocky asubrocky marked this pull request as ready for review June 28, 2023 17:53
samrabelachew
samrabelachew previously approved these changes Jun 28, 2023
@samrabelachew samrabelachew dismissed their stale review June 28, 2023 21:18

need to review shutdown logic

samrabelachew
samrabelachew previously approved these changes Jun 28, 2023
@asubrocky asubrocky merged commit a3c243f into main Jun 29, 2023
2 checks passed
@asubrocky asubrocky deleted the mark-outdated-plan-checkruns-as-aborted branch June 29, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants