Skip to content

Commit

Permalink
actually still need legacyhandler
Browse files Browse the repository at this point in the history
  • Loading branch information
smonero committed Aug 13, 2024
1 parent eb5a0d4 commit 5d92995
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
6 changes: 5 additions & 1 deletion server/legacy/lyft/gateway/events_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,13 @@ func NewVCSEventsController(
clientCreator githubapp.ClientCreator,
defaultTFVersion string,
) *VCSEventsController {
legacyHandler := &gateway_handlers.LegacyPullHandler{

Check failure on line 63 in server/legacy/lyft/gateway/events_controller.go

View workflow job for this annotation

GitHub Actions / runner / gotest

undefined: gateway_handlers.LegacyPullHandler

Check failure on line 63 in server/legacy/lyft/gateway/events_controller.go

View workflow job for this annotation

GitHub Actions / runner / golangci-lint

undefined: gateway_handlers.LegacyPullHandler (typecheck)

Check failure on line 63 in server/legacy/lyft/gateway/events_controller.go

View workflow job for this annotation

GitHub Actions / runner / golangci-lint

undefined: gateway_handlers.LegacyPullHandler) (typecheck)
Logger: logger,
VCSStatusUpdater: vcsStatusUpdater,
}
prSignaler := &pr.WorkflowSignaler{TemporalClient: temporalClient, DefaultTFVersion: defaultTFVersion}
prRequirementChecker := requirement.NewPRAggregate(globalCfg)
modifiedPullHandler := gateway_handlers.NewModifiedPullHandler(logger, asyncScheduler, rootConfigBuilder, globalCfg, prRequirementChecker, prSignaler)
modifiedPullHandler := gateway_handlers.NewModifiedPullHandler(logger, asyncScheduler, rootConfigBuilder, globalCfg, prRequirementChecker, prSignaler, legacyHandler)
closedPullHandler := &gateway_handlers.ClosedPullRequestHandler{
Logger: logger,
PRCloseSignaler: prSignaler,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ import (
"github.com/runatlantis/atlantis/server/models"
)

type legacyHandler interface {
Handle(ctx context.Context, request *http.BufferedRequest, event PullRequest, allRoots []*valid.MergedProjectCfg) error
}

type prSignaler interface {
SignalWithStartWorkflow(ctx context.Context, rootCfgs []*valid.MergedProjectCfg, prRequest pr.Request) (client.WorkflowRun, error)
}
Expand All @@ -29,6 +33,7 @@ type ModifiedPullHandler struct {
RootConfigBuilder rootConfigBuilder
GlobalCfg valid.GlobalCfg
RequirementChecker requirementChecker
LegacyHandler legacyHandler
PRSignaler prSignaler
}

Expand All @@ -41,13 +46,14 @@ type PullRequest struct {
InstallationToken int64
}

func NewModifiedPullHandler(logger logging.Logger, scheduler scheduler, rootConfigBuilder rootConfigBuilder, globalCfg valid.GlobalCfg, requirementChecker requirementChecker, prSignaler prSignaler) *ModifiedPullHandler {
func NewModifiedPullHandler(logger logging.Logger, scheduler scheduler, rootConfigBuilder rootConfigBuilder, globalCfg valid.GlobalCfg, requirementChecker requirementChecker, prSignaler prSignaler, legacyHandler legacyHandler) *ModifiedPullHandler {
return &ModifiedPullHandler{
Logger: logger,
Scheduler: scheduler,
RootConfigBuilder: rootConfigBuilder,
GlobalCfg: globalCfg,
RequirementChecker: requirementChecker,
LegacyHandler: legacyHandler,
PRSignaler: prSignaler,
}
}
Expand Down Expand Up @@ -97,6 +103,7 @@ func (p *ModifiedPullHandler) handle(ctx context.Context, request *http.Buffered
}

fxns := []func(ctx context.Context, request *http.BufferedRequest, event PullRequest, allRoots []*valid.MergedProjectCfg) error{
p.LegacyHandler.Handle,
p.handlePlatformMode,
}
var combinedErrors *multierror.Error
Expand Down

0 comments on commit 5d92995

Please sign in to comment.