Skip to content

Fix for 2091 #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Fix for 2091 #2290

merged 1 commit into from
May 23, 2025

Conversation

marcusbritanicus
Copy link
Contributor

No description provided.

@tsujan
Copy link
Member

tsujan commented May 23, 2025

When both task-bars are set to show only windows on their own screens:

If a window is started on a screen, it'll be shown only on its task-bar, as expected. But if the window is moved to the other screen, the behavior will be totally erratic and could result in no task button after some movements between screens.

I guess the problem is in LXQtTaskbarWlrootsBackend::isWindowOnScreen.

EDIT: The problem was in LXQtTaskbarWlrootsBackend::onOutputsChanged: it should emit a geometry change.

Side note:
I'd be very grateful if you give good titles to PRs and refer to their corresponding issues in their main comments by using "closes" or "fixes". The reason is that a title like this will make it hard to make a changelog later.

@tsujan
Copy link
Member

tsujan commented May 23, 2025

There's another problem not related to what I mentioned above:

LXQtTaskbarWlrootsWindow::outputsChanged should be disconnected appropriately on some occasions. Please see where the slot LXQtTaskbarWlrootsBackend::onStateChanged is disconnected in the code.

@tsujan
Copy link
Member

tsujan commented May 23, 2025

OK, I fixed all problems, but since this PR isn't made inside LXQt, I can't add the fixes here. So, I merge it and will make another PR.

Thanks again for writing the core codes, without which we couldn't have Wayland support in lxqt-panel. Please keep up the good work!

@tsujan tsujan merged commit c62f043 into lxqt:master May 23, 2025
@tsujan
Copy link
Member

tsujan commented May 23, 2025

The PR is here: #2291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants