Hide dock titlebars

[xiota]

The dock functions are self-explanatory when filled. This hides the dock titles to save a small amount of vertical screen space.

[tsujan]

Seems like cluttering preferences to me. In LXQt, we try to add options only when they're practically needed. While the other options you added were practical, this one isn't, IMO.

[xiota]

This one doesn't add an option. It just hides the title bars. It's like two lines.

[tsujan]

Oh, sorry! The titles are needed; not everyone knows what they are. I thought you knew that and added options.

[xiota]

No. I think it's self explanatory that the tiny images are thumbnails and the list of text is Exif data, so the title bars aren't necessary. I could modify it so the Exif data is filled with text that says something like, "Metadata is unavailable for this image." That way there isn't an ambiguous blank box when there is no metadata.

Otherwise, this is a quick take-it-or-leave-it PR depending on your personal preference. If you want to pass, you can close this and just move on to the next one.

[tsujan]

... depending on your personal preference.

Only the original author creates the app according to his/her preferences; the rest is about respecting his design, being practical and ignoring personal preferences/tastes/habits.

[xiota]

I didn't look at the initial commit log to see who the original author is. But since you control the repository, you pretty much decide what gets added. As you noted, it would be cluttering the preferences dialog for a tiny visual change. I'd welcome suggestions that would make this more acceptable for inclusion. If not, it's not a problem to go on to other PRs for more practical features.

[tsujan]

The original author is PCMan. In LXQt, I follow his design, both in GUI and in code. I've made a Qt-only image viewer for my personal use because I prefer a different design but added (and will add) some of its practical features to lximage-qt.

I close this because, as you implied, it isn't worth adding an option.

to go on to other PRs for more practical features.

I already merged another PR by you.

[xiota]

What is the design you prefer? What features are you planning to port?

[tsujan]

What is the design you prefer?

In this special case, only a simple image viewer without editing features. Not so popular.

What features are you planning to port?

Have ported some of them but haven't had time for this one yet: #192

[PCMan]

Hi @tsujan if you have some good idea, please go ahead. Don't worry about who's the original author or what the original design was. I haven't worked on the project for quite a long time for personal reasons.
It's free software and I'm happy to see others working on it.

As long as you guys are working on something that's helpful to the users I'm going to respect your decisions.
Thanks!

[tsujan]

@PCMan
Respecting the original author's design is a practical approach. Each app has a kind of identity; if we break it, we'll create a mess after a while. As someone who has worked with your codes a lot, I can say with certainty that your designs — and especially, your code structures — have been most flexible.