Fix symbols conflict on static build #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luis-pereira
reviewed
Jul 1, 2020
| @@ -777,6 +777,7 @@ QSize XdgIconLoaderEngine::actualSize(const QSize &size, QIcon::Mode mode, | |||
| return {0, 0}; | |||
| } | |||
|
|
|||
| #ifndef QTXDG_STATIC_BUILD | |||
There was a problem hiding this comment.
@ilya-fedin How will be QTXDG_STATIC_BUILD toggled ?
There was a problem hiding this comment.
Since upstream cmake files have only SHARED variant, it could be defined in custom cmake files in a project that want to link with libqtxdg statically
There was a problem hiding this comment.
Making have an STATIC variant is really easy, CMake supports it. Will do it.
Pushing it to this branch, Ok ?
|
@ilya-fedin Can you rebase ? |
To avoid symbol conflict with Qt
|
Rebased |
|
@ilya-fedin See #215 |
|
I'm not interested in this anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208