Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicts with QtGui symbols on static link #208

Closed
ilya-fedin opened this issue May 6, 2020 · 4 comments · May be fixed by #215
Closed

Conflicts with QtGui symbols on static link #208

ilya-fedin opened this issue May 6, 2020 · 4 comments · May be fixed by #215

Comments

@ilya-fedin
Copy link

When linking QtGui and libqtxdg statically to an app, QIconCacheGtkReader and PixmapEntry::pixmap with the ones from qiconloader.cpp

Expected Behavior

libqtxdg should work with static link

Current Behavior

https://github.com/ilya-fedin/tdesktop/runs/645416587?check_suite_focus=true

Possible Solution

Maybe, hide them under namespace? 🤔

Steps to Reproduce (for bugs)
  1. Link an app statcally with QtGui and XDGIconLoader at the same time
Context

I tried to link tdesktop static binary with lxqt-qtplugin to allow it to get lxqt system settings (fonts, icon theme, etc), but it requires xdgiconloader from libqtxdg, that has this issue :(

System Information

I hope, this is unrelated (but you have a link to the GH action job) :)
@luis-pereira
Copy link
Member

Maybe, hide them under namespace? thinking

That's a possible solution. But, I have not looked into it, yet.

@ilya-fedin
Copy link
Author

ilya-fedin commented May 30, 2020 •
edited
Loading

If they're needed just because these symbols aren't exported, maybe just add a QTXDG_STATIC_BUILD define and hide these declarations with #ifndef? 🤔
Something similar is done in tdesktop: https://github.com/telegramdesktop/tdesktop/blob/dev/Telegram/SourceFiles/qt_functions.cpp

@ilya-fedin
Copy link
Author

It works for me with these changes: https://github.com/ilya-fedin/libqtxdg/commits/fix-static-build
If it is OK for you, I can open a PR.

@ilya-fedin ilya-fedin mentioned this issue Jun 29, 2020
Closed
@ilya-fedin
Copy link
Author

I opened #212

@luis-pereira luis-pereira mentioned this issue Jul 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ilya fedin fix static build lxqt/libqtxdg
Fix symbols conflict on static build
2 participants
@luis-pereira @ilya-fedin