Re-arrange net_* files efficiently #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjalidk
force-pushed
the
net2
branch
2 times, most recently
from
52635c2
to
6f47094
Compare
|
Hi @hallyn did you get a chance to review the code? |
Moved common functionality between net_*.c files into net.c. Moved the handle_*_resp() calls for route, arp & if into handle_net_resp() Added new tests/IF directory for interface statistics. Removed the path outside while loop as it will never be run. Added err1 and err2 paths for error handling in net.c Fixed issues in net_if.c - missing bzero for ifs, and writing the interface name when TESTING is not enabled. Also added some extra prints and a free in tests/IF/if_test.c Signed-off-by: Anjali Kulkarni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved common functionality between net_*.c files into net.c.
Added connect_netlink() & get_net_len() common from all net_*.c files into net.c