Add "TLB size" to /proc/cpuinfo parsing. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anjali Kulkarni <[email protected]>
hallyn
approved these changes
Jan 24, 2024
|
mem test failed? |
|
(patch itself looks good) |
|
Yes, I have been looking at it, but can’t understand it - downloaded the artifacts as well - it works on the machines I have tried. There should be no reason for failure from the code side of it. It almost looks like -DTESTING is not set for this file, but that is also not true.
Any ideas why it may be failing? It does not fail on any of my machines. Maybe I should try on different VM.
Anjali
… On Jan 24, 2024, at 6:15 AM, Serge Hallyn ***@***.***> wrote:
mem test failed?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I think that: The 'diff' at the end of mem.sh is showing there are differences. Since it is the last command in this shell, and it returns an error, the shell returns an error. So the github action is counted as failed. If the diff is just for informational purposes, then do diff ... || true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "TLB size" to /proc/cpuinfo parsing.