-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new block's page property #418
base: master
Are you sure you want to change the base?
Conversation
…a-module-cms into block-page-property
New unit test was added. Updates to guide will be done afterwards... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in generel, we have to discuss this change because the interfaces changes, which is a clear BC break, and must be released along with 6.0
I assumed that a minor release can deal with that BC break along with the deprecated annotation. |
no, if someone implement that interface this will break the application
It would be better to first trigger deprecation notices, its better migration path for developers 👍 |
What are you changing/introducing
page
property for blocks in both admin and frontend context as a replacement forgetEnvOption('pageObject')
resp.getPageObject()
, which is now deprecatedtestPageObjectPlaceholderIteration()
and thereforeTestingPageObjectBlock
testConcretImplementation()
→testConcreteImplementation()
ConcretImplementationBlock
→ConcreteImplementationBlock
What is the reason for changing/introducing
QA