Added PHP type declarations in page getter/setter

luyadev · Apr 6, 2024 · 4a5ab13 · 4a5ab13
1 parent 574f64f
commit 4a5ab13
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/src/base/BlockInterface.php b/src/base/BlockInterface.php
@@ -2,6 +2,8 @@
 
 namespace luya\cms\base;
 
+use luya\cms\models\NavItemPage;
+
 /**
  * Interface for all Blocks.
  *
@@ -102,14 +104,14 @@ public function getFieldHelp();
      *
      * @param NavItemPage $page The page object.
      */
-    public function setPage($page);
+    public function setPage(NavItemPage $page);
 
     /**
      * Returns the block's {{luya\cms\models\NavItemPage}} object.
      *
      * @return NavItemPage
      */
-    public function getPage();
+    public function getPage(): NavItemPage;
 
     /**
      * Set an environment option informations to the block with key value pairing.

diff --git a/src/base/InternalBaseBlock.php b/src/base/InternalBaseBlock.php
@@ -4,6 +4,7 @@
 
 use luya\admin\base\TypesInterface;
 use luya\cms\frontend\blockgroups\MainGroup;
+use luya\cms\models\NavItemPage;
 use luya\helpers\ArrayHelper;
 use luya\helpers\FileHelper;
 use luya\helpers\Html;
@@ -295,15 +296,15 @@ public function isFrontendContext()
     /**
      * @inheritdoc
      */
-    public function setPage($page)
+    public function setPage(NavItemPage $page)
     {
         $this->_page = $page;
     }
 
     /**
      * @inheritdoc
      */
-    public function getPage()
+    public function getPage(): NavItemPage
     {
         return $this->_page;
     }

diff --git a/tests/data/blocks/ConcreteImplementationBlock.php b/tests/data/blocks/ConcreteImplementationBlock.php
@@ -4,6 +4,7 @@
 
 use luya\cms\base\BlockInterface;
 use luya\cms\frontend\blockgroups\DevelopmentGroup;
+use luya\cms\models\NavItemPage;
 
 class ConcreteImplementationBlock implements BlockInterface
 {
@@ -101,7 +102,7 @@ public function getFieldHelp()
      *
      * @param NavItemPage $page The page object.
      */
-    public function setPage($page)
+    public function setPage(NavItemPage $page)
     {
         $this->_page = $page;
     }
@@ -111,7 +112,7 @@ public function setPage($page)
      *
      * @return NavItemPage
      */
-    public function getPage()
+    public function getPage(): NavItemPage
     {
         return $this->_page;
     }