Add optional Spectacular AI SDK to RAE build #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serafadam
requested changes
Oct 3, 2023
Dockerfile
Outdated
| @@ -3,6 +3,8 @@ FROM luxonis/depthai-ros-rae AS builder | |||
| ARG SIM=0 | |||
| ARG CORE_NUM=1 | |||
| ARG BUILD_TYPE="RelWithDebInfo" | |||
| ARG INCLUDE_SPECTACULARAI_ROS=YES | |||
There was a problem hiding this comment.
I would set that to false and modify the workflow file to set that argument to true
.github/workflows/main.workflow.yaml
Outdated
| @@ -46,6 +46,8 @@ jobs: | |||
| ROS_DISTRO=${{ env.ROS_DISTRO }} | |||
| USE_RVIZ=1 | |||
| SIM=1 | |||
| secrets: | | |||
| "GITHUB_RAE_PAT_TOKEN=${{ secrets.GITHUB_RAE_PAT_TOKEN }}" | |||
There was a problem hiding this comment.
Needs to be changed to SPECTACULAR_AI_TOKEN
There was a problem hiding this comment.
- needs to be added to build and push sim step
Dockerfile
Outdated
| && git clone --single-branch --branch ${SPECTACULARAI_ROS_VERSION} https://github.com/SpectacularAI/ros.git sai_ros \ | ||
| && cd sai_ros \ | ||
| && apt-get -y install unzip --no-install-recommends \ | ||
| && ROS_DISTRO=$ROS_DISTRO DEPTHAI_WS=$UNDERLAY_WS GITHUB_RAE_PAT_TOKEN=$(cat /run/secrets/GITHUB_RAE_PAT_TOKEN) . ./scripts/download_and_build_static.sh \ |
There was a problem hiding this comment.
Change /run/secrets/GITHUB_RAE_PAT_TOKEN to /run/secrets/SPECTACULAR_AI_TOKEN
|
@Bercon hi, are there any usage examples? I've seen a Spectacular AI demo in one of the previous Kickstarter updates. Looks cool. Any references would be greatly appreciated. Update: I just checked the repo. So it's for commercial usage only? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include Spetacular AI SDK in RAE Docker image