Extend NN Archive Generation Test Coverage #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkbmrz
changed the title
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
conorsim
approved these changes
Mar 22, 2024
| for i in range(10): | ||
| img = np.random.randint(0, 256, (10, 10, 3), dtype=np.uint8) | ||
| img_file_path = os.path.join(cls.tmp_path, "images", f"img{i}.png") | ||
| def _make_dummy_ldf( |
There was a problem hiding this comment.
Not important and just an idea, but I could see this being useful across other tests too. We could make a LuxonisDatasetFactory as a shared factory which can be used in other tests as well.
There was a problem hiding this comment.
It might also make sense to instead implement it in luxonis-ml and import it here since it would be useful for luxonis-ml tests
There was a problem hiding this comment.
Sure, it makes sense to move it to luxonis-ml!
kozlov721
pushed a commit
that referenced
this pull request
Oct 9, 2024
* extend NN Archive generation test coverage to cover all implemented heads * [Automated] Updated coverage badge --------- Co-authored-by: GitHub Actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending test coverage of NN archive generation for each type of head in luxonis-train. For each head, we now have the following tests implemented: