Add export output names specification for individual nodes #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokovninn
requested review from
kozlov721,
klemen1999,
tersekmatija and
conorsim
and removed request for
a team
github-actions
bot
added
enhancement
klemen1999
approved these changes
Oct 11, 2024
Co-authored-by: KlemenSkrlj <[email protected]>
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
=======================================
Coverage ? 97.07%
=======================================
Files ? 139
Lines ? 6020
Branches ? 0
=======================================
Hits ? 5844
Misses ? 176
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
@klemen1999 @kozlov721 archive generation for models with multiple heads should work well now. Please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to deprecate the
output_namesconfiguration in favor ofexport_output_namesfor more granular control. It updates the documentation, configuration files, and relevant code to reflect this change.Deprecation of
output_names:configs/README.md: Markedoutput_namesas deprecated in the documentation.luxonis_train/models/luxonis_lightning.py: Added a warning message about the deprecation ofexporter.output_namesand implemented logic to usenode.export_output_namesif provided. [1] [2]Configuration updates:
configs/example_export.yaml: Removedoutput_namesand addedexport_output_namesunderhead_params. [1] [2]tests/configs/archive_config.yaml: Updated the configuration to useexport_output_namesfor various nodes.Code changes:
luxonis_train/nodes/base_node.py: Addedexport_output_namesas an attribute and updated the constructor and property methods accordingly. [1] [2] [3] [4]luxonis_train/nodes/heads/efficient_bbox_head.py: Added logic to handleexport_output_namesin the constructor.