Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference Fix #100

Merged
merged 43 commits into from
Oct 8, 2024
Merged

Inference Fix #100

merged 43 commits into from
Oct 8, 2024

Conversation

kozlov721
Copy link
Collaborator

@kozlov721 kozlov721 commented Oct 8, 2024

  • Updated visualizers so they don't require labels
  • Fixed rendering of predictions for batch_size larger than 1
  • Added tests for all inference options
  • Fixed failing pre-commit

@kozlov721 kozlov721 requested a review from a team as a code owner October 8, 2024 02:16
@kozlov721 kozlov721 requested review from klemen1999, tersekmatija and conorsim and removed request for a team October 8, 2024 02:16
@kozlov721 kozlov721 added the fix Fixing a bug label Oct 8, 2024
@kozlov721 kozlov721 self-assigned this Oct 8, 2024
Copy link
Contributor

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from docs/readme-updates to dev October 8, 2024 20:44
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 98.38710% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@a6c99f9). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...d_modules/visualizers/classification_visualizer.py 88.88% 1 Missing ⚠️
tests/integration/test_simple.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #100   +/-   ##
======================================
  Coverage       ?   97.13%           
======================================
  Files          ?      139           
  Lines          ?     6002           
  Branches       ?        0           
======================================
  Hits           ?     5830           
  Misses         ?      172           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozlov721 kozlov721 merged commit e525054 into dev Oct 8, 2024
9 checks passed
@kozlov721 kozlov721 deleted the fix/inference branch October 8, 2024 23:40
kozlov721 added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants