Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Filtering Issue & Mosaic Transformation Logic Improvement #186

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

JSabadin
Copy link
Contributor

@JSabadin JSabadin commented Oct 4, 2024

Bug Fix: Filtering Issue & Mosaic Transformation Logic Improvement

Overview

This pull request addresses a bug in the filtering process for batch transformations and includes a revision of the logic for mosaic transformations.

Key Changes:

  • Bug Fix: Resolved an issue where filtering in batch transformations was not functioning as expected.
  • Mosaic Logic Update: Revised the mosaic transformation logic.

Visual appearance of the new mosaic.
image

@JSabadin JSabadin requested a review from a team as a code owner October 4, 2024 16:40
@JSabadin JSabadin requested review from kozlov721, klemen1999, tersekmatija and conorsim and removed request for a team October 4, 2024 16:40
@github-actions github-actions bot added the fix Fixing a bug label Oct 4, 2024
@JSabadin
Copy link
Contributor Author

JSabadin commented Oct 4, 2024

Please do not merge this yet. There is a issue at this location that's causing the loading process to fail. I will investigate it further. It seems to be related to the indices. I was using only two images in the dataset during testing. Please ignore this. It occurred because the dataset size was mistakenly set to 1.

@JSabadin JSabadin changed the title Fix keypoints filtering for mosaic aug Bug Fix: Filtering Issue & Mosaic Transformation Logic Improvement Oct 4, 2024
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@JSabadin
Copy link
Contributor Author

JSabadin commented Oct 4, 2024

Not ready to be merged yet. I'm working on the last issue.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@de1d69f). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #186   +/-   ##
======================================
  Coverage       ?   92.41%           
======================================
  Files          ?       79           
  Lines          ?     4126           
  Branches       ?        0           
======================================
  Hits           ?     3813           
  Misses         ?      313           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@kozlov721 kozlov721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JSabadin
Copy link
Contributor Author

JSabadin commented Oct 4, 2024

Fixed the issue where images were not aligned properly before cropping. Now, more information is preserved from the image.

Initial Image

In the first image, you can see how the misaligned cropping caused some information to be lost:

Misaligned Cropping

In the second image, the issue is fixed, and more information is retained from the original image:

Fixed Cropping

@JSabadin JSabadin merged commit a81ac30 into dev Oct 4, 2024
12 checks passed
@kozlov721 kozlov721 mentioned this pull request Oct 7, 2024
@kozlov721 kozlov721 deleted the fix/mosaic branch October 8, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants