Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-Request] Missing standard (?) frame camera_depth_optical_frame #628

Open
flabrosse opened this issue Nov 15, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@flabrosse
Copy link

rtabmap requires the frame camera_depth_optical_frame as the frame for the depth image. There seems to be no way to configure this in rtabmap. Other cameras provide this frame, such as the realsense, the gazebo kinect driver and probably the ZED (although I cannot check this right now).

It is obviously easy to add a static transform from a provided frame to the needed one, but it would be even better integration if the depthai-ros driver would conform to what seems to be a standard naming of camera frames. There are other frames that seem to be standard, such as camera_color_optical_frame and camera_imu_optical_frame.

@flabrosse flabrosse added the enhancement New feature or request label Nov 15, 2024
@Serafadam
Copy link
Collaborator

Hi,

  1. Unless I'm wrong there shouldn't be a requirement for a specific frame name, rtabmap.launch.py works with RGBD frames and doesn't throw any errors regarding them, the most important frame is the base_frame which can be overriden.
  2. Unfortunately there is no REP (yet) for specifying the frame names (not counting optical_frames)
  3. If you enable RS mode (more information in the docs), the topic and frame names will be remapped to match those on Realsense

@flabrosse
Copy link
Author

I found what the issue is.

With the camera simulated by gazebo, the frame_ID is set to the non-existent camera_depth_optical_frame:

---
header:
  stamp:
    sec: 190
    nanosec: 447000000
  frame_id: camera_depth_optical_frame

The frame given by the real camera is oak_rgb_camera_optical_frame:

header:
  stamp:
    sec: 1732099885
    nanosec: 990851146
  frame_id: oak_rgb_camera_optical_frame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants