Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: ImgDetectionsExtended masks should be set if specified in the function call #137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aljazkonec1
Copy link
Contributor

When a segmentation + detection model like YOLO-P has no detections, the create_detection_message should set the masks parameter to the output shape of the model with -1 as values. This kind of mask is already created in yolo.py parser but not properly processed when no detections are found.

@github-actions github-actions bot added enhancement New feature or request parsers Changes affecting ml.parsers labels Nov 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.31%. Comparing base (37a2d92) to head (fd3b592).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
depthai_nodes/ml/parsers/yolo.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   33.40%   33.31%   -0.09%     
==========================================
  Files          68       68              
  Lines        3739     3698      -41     
==========================================
- Hits         1249     1232      -17     
+ Misses       2490     2466      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request parsers Changes affecting ml.parsers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants