Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging in E2E tests. #133

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Better logging in E2E tests. #133

merged 4 commits into from
Nov 18, 2024

Conversation

kkeroo
Copy link
Collaborator

@kkeroo kkeroo commented Nov 14, 2024

This PR improves logging in GH actions. Now, The besides the test status (FAILED, SKIPPED) also reason is given e.g. Can't connect to the device... or Pipeline crashed etc.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.20%. Comparing base (37a2d92) to head (8c20ec0).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   33.40%   33.20%   -0.21%     
==========================================
  Files          68       68              
  Lines        3739     3765      +26     
==========================================
+ Hits         1249     1250       +1     
- Misses       2490     2515      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jkbmrz jkbmrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkeroo kkeroo merged commit 45e910a into main Nov 18, 2024
10 checks passed
@kkeroo kkeroo deleted the tests/logging branch November 18, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants