-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsers and Messages V2 #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for different input sizes. * Support extended palm detection in examples. * Pre-commit fix. * Add normalization.
…r characters. This PR adds a classification_sequence_message that returns a sequence of charecters corresponding to maximum probability in the sequence. The message has optional parameters to remove duplicates and ignore background class indexes. In addition this PR also adds a PaddleOCR Parser, which utilizes the classification_sequence message.
Co-authored-by: KlemenSkrlj <[email protected]>
* Add LaneDetectionParser. * Add tests. * Add LaneDetection parser to parsers. * Example added. * typo. * Precommit fix. * [Automated] Updated coverage badge --------- Co-authored-by: GitHub Actions <[email protected]>
* fix: ParsingNeuralNetwork build overload method names * fix: YoloExtendedParser imports * fix: remove double-calling the np.array() * fix: make sure we pass floats to the ImgDetectionExtended setters
* Add keypoint confidences to YOLO. * Refactor FastSAM. * Fix Yolo build method. * Get subtype from archive instead of yolo_version. * Typo. * Move mask related functions. * Docstring fix. * Docstring fix. * Remove comments. * Change yolo_version to subtype. * Update arguments. * Update depthai_nodes/ml/parsers/yolo.py Co-authored-by: KlemenSkrlj <[email protected]> * Docstring fix. Co-authored-by: KlemenSkrlj <[email protected]> * Docstring param description fix. Co-authored-by: KlemenSkrlj <[email protected]> * Error printing fix. Co-authored-by: KlemenSkrlj <[email protected]> --------- Co-authored-by: KlemenSkrlj <[email protected]>
* Add a simple parser for embeddings models * add setOutputLayerNames set method
* fix: update config usage to latest DAIv3 version * fix: clip scores in HRNetParser * feat: allow keypoints message creation with no conf threshold * refactor: unify docstrings * feat: remove run() method and output_layer_name parameter from the DetectionParser * refactor: unify the order of parser methods * feat: add missing setters and unify existing ones * feat: remove default values from DetectionParser * feat: move score_threshold from children to KeypointParser * feat: unify how to handle missing output names * feat: remove default output_layer_name option for HRNetParser * feat: call head_config arguments with .get() to prevent errors * updated pre-commit version * added manual end2end test script * feat: refactor messages * fix: creators unittests * feat: remove SegmentationMask message * fix: pre-commit formatting * Correct build in PalmDetection parser. * Correct build in PPTextDetection parser. * Correct build in SCRFD. * Small fix in YuNet. * Python v3.8 supported. * Python v3.8 support in helpers. * Use alpha4. * Small SCRFD fix. * fix: ImageOutputParser get outputs * fix: MapOutputParser set timestamp * feat: rename SegmentationMasks to SegmentationMask * feat: force keypoint and bbox coordinates to 0-1 * fix: PPTextDetectionParser docstring * fix: keypoint and bbox requirements * Boundaries fix. * Masks fix. * feat: modify masks setter and getter methods in ImgDetectionsExtended message --------- Co-authored-by: klemen1999 <[email protected]> Co-authored-by: kkeroo <[email protected]>
github-actions
bot
added
messages
Changes affecting ml.messages
parsers
Changes affecting ml.parsers
examples
Changes affecting examples.
release
New version release
labels
Oct 24, 2024
Test Results125 tests 125 ✅ 1s ⏱️ Results for commit 78d2914. |
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
jkbmrz
requested review from
tersekmatija,
kkeroo and
klemen1999
as code owners
October 24, 2024 13:27
klemen1999
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, already checked when merging from parsers-v2
branch to dev
kkeroo
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the
dev
branch into themain
for the v0.0.3 release of thedepthai-nodes
library. Primarily, it updates how parsers are structured (as defined by theBaseParser
) and built - manually (1) during or (2) after initialization (using setters), or (3) automatically by calling thebuild()
method. The latter allows building the parser from aNN Archive
(see the newly addedParserGenerator
). Moreover, we are adding theParsingNeuralNetwork
node that wraps theNeuralNetwork
node with parsing capabilities. Additionally, we have updated numerous parsers, messages and creator functions.Overview:
BaseParser
that defines basic parser structure and that all parsers must inherit from.ClassificationSequenceParser
,DetectionParser
,EmbeddingsParser
,LaneDetectionParser
,MapOutputParser
,PPTextDetectionParser
,RegressionParser
,XFeatMonoParser
,XFeatStereoParser
(+ relevant utils);AgeGenderParser
,MPHandLandmarkParser
,MonocularDepthParser
,ThermalImageParser
,XFeatParser
(+ relevant utils);Cluster
/s
,Keypoint
,Map2D
,Prediction
/s
,SegmentationMask
(+ relevant utils);ImgDetectionExtended
: bbox coordinates changed from xyxy to xywh and must be relative;Keypoints
: keypoint coordinates must be relative;HandKeypoints
,AgeGender
,SegmentationMasks
(+ relevant utils);ParserGenerator
, a general interface for instantiating parsers from NN Archives;ParsingNeuralNetwork
node that wraps the NeuralNetwork node and adds parsing capabilities;TilesPatcher
andTiling
helper nodes (+ relevant utils);pre-commit
version