prune incremental config & misc #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `stg_todo`, `fact_todos` now have `is_incremental` config block & postgres based config
- added surrogate key for `fact_todos`
- embedded drop null from `fact_todos` into `stg_todos`
- added tests to said models.
- list and folders don't need this - seed dates & src tasks raw dont need full refresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<!---
Provide a short summary in the Title above. Examples of good PR titles:
"Feature: add so-and-so models"
"Fix: deduplicate such-and-such"
"Update: dbt version 0.13.0"
-->
Description & motivation
<!---
Describe your changes, and why you're making them. Is this linked to an open
issue, a Trello card, or another pull request? Link it here.
-->
To-do before merge
<!---
(Optional -- remove this section if not needed)
Include any notes about things that need to happen before this PR is merged, e.g.:
Change the base branch
Update dbt Cloud jobs
Ensure PR #56 is merged
-->
Screenshots:
<!---
Include a screenshot of the relevant section of the updated DAG. You can access
your version of the DAG by running
dbt docs generate && dbt docs serve.-->
Validation of models:
<!---
Include any output that confirms that the models do what is expected. This might
be a link to an in-development dashboard in your BI tool, or a query that
compares an existing model with a new one.
-->
Changes to existing models:
<!---
Include this section if you are changing any existing models. Link any related
pull requests on your BI tool, or instructions for merge (e.g. whether old
models should be dropped after merge, or whether a full-refresh run is required)
-->
Checklist:
<!---
This checklist is mostly useful as a reminder of small things that can easily be
forgotten – it is meant as a helpful tool rather than hoops to jump through.
Put an
xin all the items that apply, make notes next to any that haven't beenaddressed, and remove any items that are not relevant to this PR.
-->
My pull request represents one logical piece of work.
My commits are related to the pull request and look clean.
My SQL follows the style guide.
I have materialized my models appropriately.
I have added appropriate tests and documentation to any new models.
I have updated the README file.
{%- if project.warehouse == 'redshift' %}
I have added sort and dist keys to models materialized as tables.
I have validated the SQL in any late-binding views.
{% endif %}