Reduce time to change cursor #1375
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an element has large number of child elements, changing its style cusor is slow because of style recalculations. https://issues.chromium.org/issues/40493007 The original codes changes container's style.cusor but it's slow when the container has lots of child elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an element has large number of descendant elements, changing its style cusor takes some time on Chromium because of style recalculations. https://issues.chromium.org/issues/40493007
This becomes an issue because Netron changes mouse cursor before and after of panning the graph.
The original code changes container's style.cusor but it's slow when the container has lots of descendant elements.
This can be confirmed with models like efficientdet-d3.onnx file. The slow response of pointerdown (due to changing mouse cursor) is quite obvious with not very fast computers such as Rasberry Pi 5.
#1013 is related.