Tensor and Connection sidebar return to Node sidebar on close #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutzroeder
changed the title
lutzroeder
added a commit
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change means that the Tensor Properties and Connection Properties sidebars now return back to the Node Properties sidebar after closing (if the Node Properties sidebar was previously open). Note that Node Properties still resets the sidebar stack, so visiting a Node sidebar through a Connection sidebar and then closing the Node sidebar will close the entire sidebar UI, not return back to the Connection sidebar.
This change is a stylistic one, but I think makes sense given that if a user wants to inspect all of the tensors for a given node, they no longer have to reselect the node from the graph after inspecting the first tensor.