End-to-end "pp-spartan" verification contract #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storojs72
force-pushed
the
pp-spartan-merge
branch
from
ebcabe1 to
92f3793
Compare
storojs72
force-pushed
the
pp-spartan-merge
branch
from
92f3793 to
e730f26
Compare
huitseeker
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
In the interest of future switch to grumpkin, it may be useful to name things pp-compressed-pasta, or some variant of this naming scheme, just so there's not mistaking data generated for pasta for something else.
Otherwise, this looks great to me!
Congrats to you both (@storojs72 and @samuelburnham ) for making this happen!
|
|
||
| - name: Check proof verification status | ||
| run: | | ||
| [[ $(cast call ${{steps.deployment.outputs.CONTRACT_ADDRESS}} "verify(uint32,uint256[],uint256[])(bool)" "3" "[1]" "[0]" --private-key $ANVIL_PRIVATE_KEY --rpc-url $ANVIL_URL) == true ]] && exit 0 || exit 1 |
storojs72
added a commit
that referenced
this pull request
Oct 15, 2023
* End-to-end "pp-spartan" verification contract (#25) * Add JSONs generated by pp-spartan * Separate path (src/blocks/) for low-level crypto building blocks * Add e2e verification contract skeleton * Move FieldLib and PolyLib code to Utilities.sol file * Step 1 * Step 2 * CI adjustments * Update README * Update integration testing infrastructure * End-to-end "pp-spartan" verification contract (Step 3) (#27) * Add PolyEvalInstance building block * Refactor building blocks * Add step 3 of verification to the e2e contract * Remove data contracts for step 2 and step 3 * Adjust CI * KeccakTranscript and Sumcheck blocks adjustments * Requested changes * Update Utilities.sol --------- Co-authored-by: Artem Storozhuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts series of PRs aimed to move the pp-spartan branch to the main one. It contains some important changes in the overall repository organisation as well as grounding the possibility of overall verification logic testing with a help of Anvil node instead of isolated testing of partial verification with a help of data contracts which we used previously.
More specifically this PR:
pushToProof,pushToVkandverifyfunctions. First two ones are used for loading the proof and public parameters data correspondently, and last one is used for invoking the e2e verification logic;The parallel work on #22 is performing at the current moment. Once it is finished, the integration testing of e2e verification can be enforced by CI.
P.S.: while working on this PR, I had to include the pp-spartan JSONs into the codebase in addition to already existed (I suppose temporarily) ones for "regular" Spartan. In this regards, the idea of including the Rust binary that could generate us necessary JSONs comes to my mind: #24